Actions
Issue #1795
closedSome files in vendor/replicant/ still contains vendor/cm/ path
Status:
Closed
Priority:
Normal
Assignee:
Category:
Build system
Target version:
Start date:
04/26/2017
Due date:
% Done:
100%
Estimated time:
Resolution:
fixed
Device:
Grant:
Type of work:
Description
When I try to port to a new device, I decided to use the common_mini_tablet_wifionly configuration.
However, it told me that "vendor/cm/config/common.mk" is not found.
Here's my result of checking this problem:
icenowy@e531 [ replicant ] $ grep -r 'vendor/cm' vendor/replicant/ vendor/replicant/config/common.mk:-include vendor/cm-priv/keys/keys.mk vendor/replicant/config/common_mini_tv.mk:$(call inherit-product, vendor/cm/config/common_mini.mk) vendor/replicant/config/common_full_tablet_wifionly.mk:PRODUCT_PACKAGE_OVERLAYS += vendor/cm/overlay/dictionaries vendor/replicant/config/common_mini_phone.mk:$(call inherit-product, vendor/cm/config/telephony.mk) vendor/replicant/config/common_full_tv.mk:$(call inherit-product, vendor/cm/config/common_full.mk) vendor/replicant/config/common_mini.mk:$(call inherit-product, vendor/cm/config/common.mk) vendor/replicant/build/tasks/generate_cmsdk_coverage.mk:api_text_description := vendor/cmsdk/api/cm_current.txt vendor/replicant/build/tasks/apicheck.mk:# (See vendor/cmsdk/Android.mk) vendor/replicant/build/core/config.mk:FRAMEWORK_CM_PLATFORM_API_FILE := $(TOPDIR)vendor/cmsdk/api/cm_current.txt vendor/replicant/build/core/config.mk:FRAMEWORK_CM_PLATFORM_REMOVED_API_FILE := $(TOPDIR)vendor/cmsdk/api/cm_removed.txt vendor/replicant/build/core/config.mk:FRAMEWORK_CM_PLATFORM_SYSTEM_API_FILE := $(TOPDIR)vendor/cmsdk/system-api/cm_system-current.txt vendor/replicant/build/core/config.mk:FRAMEWORK_CM_PLATFORM_SYSTEM_REMOVED_API_FILE := $(TOPDIR)vendor/cmsdk/system-api/cm_system-removed.txt vendor/replicant/build/core/http_prebuilt.mk:PREBUILT_MODULE_ARCHIVE := vendor/cm/prebuilt/archive/$(LOCAL_MODULE) vendor/replicant/build/core/http_prebuilt.mk: ./vendor/cm/build/tasks/http_curl_prebuilt.sh $(1) $(2); vendor/replicant/build/tools/extract_utils.sh: export BAKSMALIJAR="$CM_ROOT"/vendor/cm/build/tools/smali/baksmali.jar vendor/replicant/build/tools/extract_utils.sh: export SMALIJAR="$CM_ROOT"/vendor/cm/build/tools/smali/smali.jar Binary file vendor/replicant/.git/index matches vendor/replicant/sepolicy/qcom/sepolicy.mk: vendor/cm/sepolicy/qcom
Should them be fixed?
Updated by Wolfgang Wiedmeyer almost 8 years ago
- Category set to Build system
Yes, this should be fixed if it breaks the port for you. But there is no need to fix all of these occurrences. Some of these files aren't needed and we want to keep the diff small between LineageOS and Replicant.
Feel free to submit a patch that fixes the issue for you!
Updated by Wolfgang Wiedmeyer almost 8 years ago
- Status changed from New to Closed
- Assignee set to Wolfgang Wiedmeyer
- % Done changed from 0 to 100
- Resolution set to fixed
Came across this when investigating an unrelated issue.
Fixed with this commit
Actions