Project

General

Profile

Actions
Copy link

Issue #2150

open
DC

libsamsung-ipc: improve board drivers print

Issue #2150: libsamsung-ipc: improve board drivers print

Added by Denis 'GNUtoo' Carikli almost 6 years ago. Updated over 5 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Telephony and mobile data
Target version:
Any version
Start date:
10/21/2020
Due date:
% Done:

0%

Estimated time:
Resolution:
Device:
Unknown
Grant:
Type of work:
C programming

DC Updated by Denis 'GNUtoo' Carikli almost 6 years ago Actions
Copy link
 #1

For many devices, we have code like that:

        rc = xmm626_kernel_smdk4412_power(client, modem_boot_fd, 1);
        rc |= xmm626_kernel_smdk4412_hci_power(client, 1);

        if (rc < 0) {
                ipc_client_log(client, "Turning the modem on failed");
                goto error;
        }

While it takes more time to write, it would be better to have two distinct
error messages:

        rc = xmm626_kernel_smdk4412_power(client, modem_boot_fd, 1);
        if (rc < 0) {
                ipc_client_log(client, "Turning the modem on failed");
                goto error;
        }

        rc = xmm626_kernel_smdk4412_hci_power(client, 1);

        if (rc < 0) {
                ipc_client_log(client, "Powering on the HCI bus failed");
                goto error;
        }

_R Updated by _I3^ RELATIVISM over 5 years ago Actions
Copy link
 #2

  • Type of work C programming added
Actions
Copy link

Also available in: PDF Atom